1 Topic by tch

  • tch
  • Guest

Topic: mach package fails

Hello,

I've just tried to build Iceweasel-UXP with the suggested --disable-sync option, but the packaging still fails.

Log is here: http://oscomp.hu/depot/iceweasel-uxp-package.log

Commands were used:

cd /tmp
git clone https://github.com/MoonchildProductions/UXP
cd UXP/application/
git clone https://git.hyperbola.info:50100/software/iceweasel-uxp.git
cd ..
wget http://oscomp.hu/depot/iceweasel-uxp.mozconfig -O .mozconfig
./mach build
.mach package

Should i set some locale parameters too?

2 Reply by g4jc

  • g4jc
  • Member
  • Offline
  • Registered: 2017-09-10
  • Posts: 44

Re: mach package fails

It looks like a locale specific issue (unable to reproduce here since en-US is set).  Try this patch, having not used ifdef inside of an .ini before, I am unsure if it will work exactly as intended. -> https://paste.debian.net/plain/1081986

you can apply the patch with "git apply". If confirmed working for you I will commit it to the tree.

3 Reply by tch

  • tch
  • Guest

Re: mach package fails

Hey, thanks, that fixed it! By this:

cd /tmp
git clone https://github.com/MoonchildProductions/UXP
cd UXP/application/
git clone https://git.hyperbola.info:50100/software/iceweasel-uxp.git
wget https://paste.debian.net/plain/1081986 -O iceweasel-uxp.locale.patch
cd iceweasel-uxp
git apply ../iceweasel-uxp.locale.patch
cd ../..
wget http://oscomp.hu/depot/iceweasel-uxp.mozconfig -O .mozconfig
./mach build
./mach package
cp ./obj-x86_64-pc-linux-gnu/dist/iceweasel-uxp-*.tar.bz2 /opt/
cd ..
rm -rf ./UXP
cd /opt
tar -xjvf iceweasel-uxp-*.tar.bz2
rm iceweasel-uxp-*.tar.bz2

i now have a portable Iceweasel-UXP in /opt. Thanks again for the help.

BTW, i also have Iceweasel 38.8 installed and it seems, that Iceweasel-UXP (52.9) shares config paths with it, because it took all the old IW-s' extensions and settings. Not my decision and not a problem for me, but i think it should not do that, since IW 38 has old extensions and IW-UXP 52 has new ones and if i would update them, then IW 38 cannot use them. While it is true, that now i could actually retire IW 38, still it can be useful for testing or other reasons to have another separate usable and trustable browser.
I've read this topic, but it is not clear to me, if this patch changes this, or just the app name. Also, if it's the first one; will it make into to the tree, or it will remain as a separate patch?

4 Reply by g4jc

  • g4jc
  • Member
  • Offline
  • Registered: 2017-09-10
  • Posts: 44

Re: mach package fails

Glad to hear the patch worked! I'll go ahead and add the locale patch to the tree.

The patch included in that topic only affects the WM_Class of the executable, so not the folder structure.
We decided to keep the original folder structure since it would break all existing profiles for users of our distro if we changed it. While that may be an option later down the road, it currently would violate our LTS distro's promise of stability.

To change the folder structure, you only need to change the "Name" and "Vendor" in iceweasel-uxp/app/application.ini. Changing these to "Iceweasel-UXP" and "Hyperbola" respectively will alter the folder structure if you wish to do that.

5 Reply by tch

  • tch
  • Guest

Re: mach package fails

I see, thanks.

I've checked for /opt/iceweasel-uxp/app/application.ini, but it wasn't there. However, i found it at /opt/iceweasel-uxp/application.ini and changed the mentioned variables, but to no avail. Nothing has changed, ~/.iceweasel-uxp has not been created and Iceweasel-UXP still uses the extensions of the old Iceweasel.

Did i misunderstood and i have to change these values before compiling? Or after compiling, but before the first run?

6 Reply by g4jc

  • g4jc
  • Member
  • Offline
  • Registered: 2017-09-10
  • Posts: 44

Re: mach package fails

This file, before compiling:
https://git.hyperbola.info:50100/softwa … on.ini#n24

7 Reply by tch

  • tch
  • Guest

Re: mach package fails

Thanks, it worked! Now everything works.

The final script to build Iceweasel-UXP:

cd /tmp
git clone https://github.com/MoonchildProductions/UXP
cd UXP/application/
git clone https://git.hyperbola.info:50100/software/iceweasel-uxp.git
sed -i 's/Vendor=Mozilla/Vendor=Hyperbola/g' iceweasel-uxp/app/application.ini
sed -i 's/Name=Firefox/Name=Iceweasel-UXP/g' iceweasel-uxp/app/application.ini
cd ..
wget http://oscomp.hu/depot/iceweasel-uxp.mozconfig -O .mozconfig
./mach build
./mach package
cp ./obj-x86_64-pc-linux-gnu/dist/iceweasel-uxp-*.tar.bz2 /opt/
cd ..
rm -rf ./UXP
cd /opt
tar -xjvf iceweasel-uxp-*.tar.bz2
rm iceweasel-uxp-*.tar.bz2

Thank you again for the help!

8 Reply by g4jc

  • g4jc
  • Member
  • Offline
  • Registered: 2017-09-10
  • Posts: 44

Re: mach package fails

Build script looks correct, but you might also want to add our patches:
https://git.hyperbola.info:50100/packag … weasel-uxp

There are three currently, I expect to have several more shortly. These are privacy fixes which were rejected upstream in the toolkit and that we would like to have in our application.

9 Reply by tch

  • tch
  • Guest

Re: mach package fails

Thanks, i'll check them.